From b1a6a5a3991cec5cd08873b01376e45d0b247f18 Mon Sep 17 00:00:00 2001
From: Marius Cramer <m.cramer@pixcept.de>
Date: Thu, 14 Nov 2013 09:05:33 -0500
Subject: [PATCH] Cleaning up code to match coding guidelines

---
 interface/lib/classes/remote.d/client.inc.php |  638 +++++++++++++++++++++++++++++----------------------------
 1 files changed, 321 insertions(+), 317 deletions(-)

diff --git a/interface/lib/classes/remote.d/client.inc.php b/interface/lib/classes/remote.d/client.inc.php
index ae5086b..e0dcad8 100644
--- a/interface/lib/classes/remote.d/client.inc.php
+++ b/interface/lib/classes/remote.d/client.inc.php
@@ -39,19 +39,19 @@
 */
 
 class remoting_client extends remoting {
-/* 
- * 
- * 
- * 
+	/*
+ *
+ *
+ *
  * 	 * Client functions
- * 
- * 
+ *
+ *
  */
 	//* Get client details
 	public function client_get($session_id, $client_id)
-    {
+	{
 		global $app;
-		
+
 		if(!$this->checkPerm($session_id, 'client_get')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 			return false;
@@ -59,51 +59,51 @@
 		$app->uses('remoting_lib');
 		$app->remoting_lib->loadFormDef('../client/form/client.tform.php');
 		$data = $app->remoting_lib->getDataRecord($client_id);
-        
-        // we need to get the new-style templates for backwards-compatibility - maybe we remove this in a later version
-        if(is_array($data) && count($data) > 0) {
-            if(isset($data['client_id'])) {
-                // this is a single record
-                if($data['template_additional'] == '') {
-                    $tpls = $app->db->queryAllRecords('SELECT CONCAT(`assigned_template_id`, \':\', `client_template_id`) as `item` FROM `client_template_assigned` WHERE `client_id` = ' . $data['client_id']);
-                    $tpl_arr = array();
-                    if($tpls) {
-                        foreach($tpls as $tpl) $tpl_arr[] = $tpl['item'];
-                    }
-                    $data['template_additional'] = implode('/', $tpl_arr);
-                    unset($tpl_arr);
-                    unset($tpls);
-                }
-            } elseif(isset($data[0]['client_id'])) {
-                // multiple client records
-                foreach($data as $index => $client) {
-                    if($client['template_additional'] == '') {
-                        $tpls = $app->db->queryAllRecords('SELECT CONCAT(`assigned_template_id`, \':\', `client_template_id`) as `item` FROM `client_template_assigned` WHERE `client_id` = ' . $client['client_id']);
-                        $tpl_arr = array();
-                        if($tpls) {
-                            foreach($tpls as $tpl) $tpl_arr[] = $tpl['item'];
-                        }
-                        $data[$index]['template_additional'] = implode('/', $tpl_arr); // dont use the $client array here - changes would not be returned to soap
-                    }
-                    unset($tpl_arr);
-                    unset($tpls);
-                }
-            }
-        }
-        
-        return $data;
+
+		// we need to get the new-style templates for backwards-compatibility - maybe we remove this in a later version
+		if(is_array($data) && count($data) > 0) {
+			if(isset($data['client_id'])) {
+				// this is a single record
+				if($data['template_additional'] == '') {
+					$tpls = $app->db->queryAllRecords('SELECT CONCAT(`assigned_template_id`, \':\', `client_template_id`) as `item` FROM `client_template_assigned` WHERE `client_id` = ' . $data['client_id']);
+					$tpl_arr = array();
+					if($tpls) {
+						foreach($tpls as $tpl) $tpl_arr[] = $tpl['item'];
+					}
+					$data['template_additional'] = implode('/', $tpl_arr);
+					unset($tpl_arr);
+					unset($tpls);
+				}
+			} elseif(isset($data[0]['client_id'])) {
+				// multiple client records
+				foreach($data as $index => $client) {
+					if($client['template_additional'] == '') {
+						$tpls = $app->db->queryAllRecords('SELECT CONCAT(`assigned_template_id`, \':\', `client_template_id`) as `item` FROM `client_template_assigned` WHERE `client_id` = ' . $client['client_id']);
+						$tpl_arr = array();
+						if($tpls) {
+							foreach($tpls as $tpl) $tpl_arr[] = $tpl['item'];
+						}
+						$data[$index]['template_additional'] = implode('/', $tpl_arr); // dont use the $client array here - changes would not be returned to soap
+					}
+					unset($tpl_arr);
+					unset($tpls);
+				}
+			}
+		}
+
+		return $data;
 	}
-	
+
 	public function client_get_id($session_id, $sys_userid)
-    {
+	{
 		global $app;
 		if(!$this->checkPerm($session_id, 'client_get_id')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 			return false;
 		}
-		
+
 		$sys_userid = $app->functions->intval($sys_userid);
-		
+
 		$rec = $app->db->queryOneRecord("SELECT client_id FROM sys_user WHERE userid = ".$sys_userid);
 		if(isset($rec['client_id'])) {
 			return $app->functions->intval($rec['client_id']);
@@ -111,19 +111,19 @@
 			throw new SoapFault('no_client_found', 'There is no sysuser account for this client ID.');
 			return false;
 		}
-		
+
 	}
-	
+
 	public function client_get_groupid($session_id, $client_id)
-    {
+	{
 		global $app;
 		if(!$this->checkPerm($session_id, 'client_get_id')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 			return false;
 		}
-		
+
 		$client_id = $app->functions->intval($client_id);
-		
+
 		$rec = $app->db->queryOneRecord("SELECT groupid FROM sys_group WHERE client_id = ".$client_id);
 		if(isset($rec['groupid'])) {
 			return $app->functions->intval($rec['groupid']);
@@ -131,228 +131,228 @@
 			throw new SoapFault('no_group_found', 'There is no group for this client ID.');
 			return false;
 		}
-		
+
 	}
-	
-	
+
+
 	public function client_add($session_id, $reseller_id, $params)
 	{
 		if (!$this->checkPerm($session_id, 'client_add'))
-			{
-					throw new SoapFault('permission_denied','You do not have the permissions to access this function.');
-					return false;
-			}
-        if(!isset($params['parent_client_id']) || $params['parent_client_id'] == 0) $params['parent_client_id'] = $reseller_id;
-		$affected_rows = $this->klientadd('../client/form/' . (isset($params['limit_client']) && $params['limit_client'] > 0 ? 'reseller' : 'client') . '.tform.php',$reseller_id, $params);
-		return $affected_rows;  
-				  
+		{
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+		if(!isset($params['parent_client_id']) || $params['parent_client_id'] == 0) $params['parent_client_id'] = $reseller_id;
+		$affected_rows = $this->klientadd('../client/form/' . (isset($params['limit_client']) && $params['limit_client'] > 0 ? 'reseller' : 'client') . '.tform.php', $reseller_id, $params);
+		return $affected_rows;
+
 	}
-	
+
 	public function client_update($session_id, $client_id, $reseller_id, $params)
 	{
-			global $app;
-			
-			if (!$this->checkPerm($session_id, 'client_update'))
-			{
-					throw new SoapFault('permission_denied','You do not have the permissions to access this function.');
-					return false;
-			}
-            
-            $app->uses('remoting_lib');
-            $app->remoting_lib->loadFormDef('../client/form/' . (isset($params['limit_client']) && $params['limit_client'] > 0 ? 'reseller' : 'client') . '.tform.php');
-            $old_rec = $app->remoting_lib->getDataRecord($client_id);
-            
-            // we need the previuos templates assigned here
-            $this->oldTemplatesAssigned = $app->db->queryAllRecords('SELECT * FROM `client_template_assigned` WHERE `client_id` = ' . $client_id);
-            if(!is_array($this->oldTemplatesAssigned) || count($this->oldTemplatesAssigned) < 1) {
-                // check previous type of storing templates
-                $tpls = explode('/', $old_rec['template_additional']);
-                $this->oldTemplatesAssigned = array();
-                foreach($tpls as $item) {
-                    $item = trim($item);
-                    if(!$item) continue;
-                    $this->oldTemplatesAssigned[] = array('assigned_template_id' => 0, 'client_template_id' => $item, 'client_id' => $client_id);
-                }
-                unset($tpls);
-            }
-            if(isset($params['template_additional'])) {
-                $app->uses('client_templates');
-                $templates = explode('/', $params['template_additional']);
-                $params['template_additional'] = '';
-                $app->client_templates->update_client_templates($client_id, $templates);
-                unset($templates);
-            }
+		global $app;
 
-            
-            if(!isset($params['parent_client_id']) || $params['parent_client_id'] == 0) $params['parent_client_id'] = $reseller_id;
-			$affected_rows = $this->updateQuery('../client/form/' . (isset($params['limit_client']) && $params['limit_client'] > 0 ? 'reseller' : 'client') . '.tform.php', $reseller_id, $client_id, $params, 'client:' . ($reseller_id ? 'reseller' : 'client') . ':on_after_update');
-			
-			$app->remoting_lib->ispconfig_sysuser_update($params,$client_id);
-			
-			return $affected_rows;
+		if (!$this->checkPerm($session_id, 'client_update'))
+		{
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+
+		$app->uses('remoting_lib');
+		$app->remoting_lib->loadFormDef('../client/form/' . (isset($params['limit_client']) && $params['limit_client'] > 0 ? 'reseller' : 'client') . '.tform.php');
+		$old_rec = $app->remoting_lib->getDataRecord($client_id);
+
+		// we need the previuos templates assigned here
+		$this->oldTemplatesAssigned = $app->db->queryAllRecords('SELECT * FROM `client_template_assigned` WHERE `client_id` = ' . $client_id);
+		if(!is_array($this->oldTemplatesAssigned) || count($this->oldTemplatesAssigned) < 1) {
+			// check previous type of storing templates
+			$tpls = explode('/', $old_rec['template_additional']);
+			$this->oldTemplatesAssigned = array();
+			foreach($tpls as $item) {
+				$item = trim($item);
+				if(!$item) continue;
+				$this->oldTemplatesAssigned[] = array('assigned_template_id' => 0, 'client_template_id' => $item, 'client_id' => $client_id);
+			}
+			unset($tpls);
+		}
+		if(isset($params['template_additional'])) {
+			$app->uses('client_templates');
+			$templates = explode('/', $params['template_additional']);
+			$params['template_additional'] = '';
+			$app->client_templates->update_client_templates($client_id, $templates);
+			unset($templates);
+		}
+
+
+		if(!isset($params['parent_client_id']) || $params['parent_client_id'] == 0) $params['parent_client_id'] = $reseller_id;
+		$affected_rows = $this->updateQuery('../client/form/' . (isset($params['limit_client']) && $params['limit_client'] > 0 ? 'reseller' : 'client') . '.tform.php', $reseller_id, $client_id, $params, 'client:' . ($reseller_id ? 'reseller' : 'client') . ':on_after_update');
+
+		$app->remoting_lib->ispconfig_sysuser_update($params, $client_id);
+
+		return $affected_rows;
 	}
-    
-    public function client_template_additional_get($session_id, $client_id) {
-        global $app;
+
+	public function client_template_additional_get($session_id, $client_id) {
+		global $app;
 
 		if(!$this->checkPerm($session_id, 'client_get')) {
 			$this->server->fault('permission_denied', 'You do not have the permissions to access this function.');
 			return false;
 		}
-        
-        if(@is_numeric($client_id)) {
-            $sql = "SELECT * FROM `client_template_assigned` WHERE `client_id` = ".$client_id;
-            return $app->db->queryOneRecord($sql);
-        } else {
-            $this->server->fault('The ID must be an integer.');
-            return array();
-        }
-    }
-    
-    private function _set_client_formdata($client_id) {
-        global $app;
-        
-        $this->id = $client_id;
-        $this->dataRecord = $app->db->queryOneRecord('SELECT * FROM `client` WHERE `client_id` = ' . $client_id);
-        $this->oldDataRecord = $this->dataRecord;
-        
-        $this->oldTemplatesAssigned = $app->db->queryAllRecords('SELECT * FROM `client_template_assigned` WHERE `client_id` = ' . $client_id);
-        if(!is_array($this->oldTemplatesAssigned) || count($this->oldTemplatesAssigned) < 1) {
-            // check previous type of storing templates
-            $tpls = explode('/', $this->oldDataRecord['template_additional']);
-            $this->oldTemplatesAssigned = array();
-            foreach($tpls as $item) {
-                $item = trim($item);
-                if(!$item) continue;
-                $this->oldTemplatesAssigned[] = array('assigned_template_id' => 0, 'client_template_id' => $item, 'client_id' => $client_id);
-            }
-            unset($tpls);
-        }
-    }
-    
-    public function client_template_additional_add($session_id, $client_id, $template_id) {
-        global $app;
-        
-		if(!$this->checkPerm($session_id, 'client_update')) {
-			$this->server->fault('permission_denied', 'You do not have the permissions to access this function.');
-			return false;
-		}
-        
-        if(@is_numeric($client_id) && @is_numeric($template_id)) {
-            // check if client exists
-            $check = $app->db->queryOneRecord('SELECT `client_id` FROM `client` WHERE `client_id` = ' . $client_id);
-            if(!$check) {
-                $this->server->fault('Invalid client');
-                return false;
-            }
-            // check if template exists
-            $check = $app->db->queryOneRecord('SELECT `template_id` FROM `client_template` WHERE `template_id` = ' . $template_id);
-            if(!$check) {
-                $this->server->fault('Invalid template');
-                return false;
-            }
-            
-            // for the update event we have to cheat a bit
-            $this->_set_client_formdata($client_id);
-            
-            $sql = "INSERT INTO `client_template_assigned` (`client_id`, `client_template_id`) VALUES (" . $client_id . ", " . $template_id . ")";
-            $app->db->query($sql);
-            $insert_id = $app->db->insertID();
-            
-            $app->plugin->raiseEvent('client:client:on_after_update',$this);
-            
-            return $insert_id;
-        } else {
-            $this->server->fault('The IDs must be of type integer.');
-            return false;
-        }
-    }
 
-    public function client_template_additional_delete($session_id, $client_id, $assigned_template_id) {
-        global $app;
-        
-		if(!$this->checkPerm($session_id, 'client_update')) {
-			$this->server->fault('permission_denied', 'You do not have the permissions to access this function.');
-			return false;
+		if(@is_numeric($client_id)) {
+			$sql = "SELECT * FROM `client_template_assigned` WHERE `client_id` = ".$client_id;
+			return $app->db->queryOneRecord($sql);
+		} else {
+			$this->server->fault('The ID must be an integer.');
+			return array();
 		}
-        
-        if(@is_numeric($client_id) && @is_numeric($template_id)) {
-            // check if client exists
-            $check = $app->db->queryOneRecord('SELECT `client_id` FROM `client` WHERE `client_id` = ' . $client_id);
-            if(!$check) {
-                $this->server->fault('Invalid client');
-                return false;
-            }
-            // check if template exists
-            $check = $app->db->queryOneRecord('SELECT `assigned_template_id` FROM `client_template_assigned` WHERE `assigned_template_id` = ' . $assigned_template_id);
-            if(!$check) {
-                $this->server->fault('Invalid template');
-                return false;
-            }
-            
-            // for the update event we have to cheat a bit
-            $this->_set_client_formdata($client_id);
-            
-            $sql = "DELETE FROM `client_template_assigned` WHERE `assigned_template_id` = " . $template_id . " AND `client_id` = " . $client_id;
-            $app->db->query($sql);
-            $affected_rows = $app->db->affectedRows();
-            
-            $app->plugin->raiseEvent('client:client:on_after_update',$this);
-            
-            return $affected_rows;
-        } else {
-            $this->server->fault('The IDs must be of type integer.');
-            return false;
-        }
-    }
-
-	public function client_delete($session_id,$client_id)
-	{
-			global $app;
-			
-			if (!$this->checkPerm($session_id, 'client_delete'))
-			{
-					throw new SoapFault('permission_denied','You do not have the permissions to access this function.');
-					return false;
-			}
-			$affected_rows = $this->deleteQuery('../client/form/client.tform.php',$client_id);
-			
-			$app->remoting_lib->ispconfig_sysuser_delete($client_id);
-			
-			return $affected_rows;
 	}
-	
-	// -----------------------------------------------------------------------------------------------
-	
-	public function client_delete_everything($session_id, $client_id)
-    {
-        global $app, $conf;
-		
-		if(!$this->checkPerm($session_id, 'client_delete_everything')) {
-        	throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
-            return false;
+
+	private function _set_client_formdata($client_id) {
+		global $app;
+
+		$this->id = $client_id;
+		$this->dataRecord = $app->db->queryOneRecord('SELECT * FROM `client` WHERE `client_id` = ' . $client_id);
+		$this->oldDataRecord = $this->dataRecord;
+
+		$this->oldTemplatesAssigned = $app->db->queryAllRecords('SELECT * FROM `client_template_assigned` WHERE `client_id` = ' . $client_id);
+		if(!is_array($this->oldTemplatesAssigned) || count($this->oldTemplatesAssigned) < 1) {
+			// check previous type of storing templates
+			$tpls = explode('/', $this->oldDataRecord['template_additional']);
+			$this->oldTemplatesAssigned = array();
+			foreach($tpls as $item) {
+				$item = trim($item);
+				if(!$item) continue;
+				$this->oldTemplatesAssigned[] = array('assigned_template_id' => 0, 'client_template_id' => $item, 'client_id' => $client_id);
+			}
+			unset($tpls);
 		}
-        
+	}
+
+	public function client_template_additional_add($session_id, $client_id, $template_id) {
+		global $app;
+
+		if(!$this->checkPerm($session_id, 'client_update')) {
+			$this->server->fault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+
+		if(@is_numeric($client_id) && @is_numeric($template_id)) {
+			// check if client exists
+			$check = $app->db->queryOneRecord('SELECT `client_id` FROM `client` WHERE `client_id` = ' . $client_id);
+			if(!$check) {
+				$this->server->fault('Invalid client');
+				return false;
+			}
+			// check if template exists
+			$check = $app->db->queryOneRecord('SELECT `template_id` FROM `client_template` WHERE `template_id` = ' . $template_id);
+			if(!$check) {
+				$this->server->fault('Invalid template');
+				return false;
+			}
+
+			// for the update event we have to cheat a bit
+			$this->_set_client_formdata($client_id);
+
+			$sql = "INSERT INTO `client_template_assigned` (`client_id`, `client_template_id`) VALUES (" . $client_id . ", " . $template_id . ")";
+			$app->db->query($sql);
+			$insert_id = $app->db->insertID();
+
+			$app->plugin->raiseEvent('client:client:on_after_update', $this);
+
+			return $insert_id;
+		} else {
+			$this->server->fault('The IDs must be of type integer.');
+			return false;
+		}
+	}
+
+	public function client_template_additional_delete($session_id, $client_id, $assigned_template_id) {
+		global $app;
+
+		if(!$this->checkPerm($session_id, 'client_update')) {
+			$this->server->fault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+
+		if(@is_numeric($client_id) && @is_numeric($template_id)) {
+			// check if client exists
+			$check = $app->db->queryOneRecord('SELECT `client_id` FROM `client` WHERE `client_id` = ' . $client_id);
+			if(!$check) {
+				$this->server->fault('Invalid client');
+				return false;
+			}
+			// check if template exists
+			$check = $app->db->queryOneRecord('SELECT `assigned_template_id` FROM `client_template_assigned` WHERE `assigned_template_id` = ' . $assigned_template_id);
+			if(!$check) {
+				$this->server->fault('Invalid template');
+				return false;
+			}
+
+			// for the update event we have to cheat a bit
+			$this->_set_client_formdata($client_id);
+
+			$sql = "DELETE FROM `client_template_assigned` WHERE `assigned_template_id` = " . $template_id . " AND `client_id` = " . $client_id;
+			$app->db->query($sql);
+			$affected_rows = $app->db->affectedRows();
+
+			$app->plugin->raiseEvent('client:client:on_after_update', $this);
+
+			return $affected_rows;
+		} else {
+			$this->server->fault('The IDs must be of type integer.');
+			return false;
+		}
+	}
+
+	public function client_delete($session_id, $client_id)
+	{
+		global $app;
+
+		if (!$this->checkPerm($session_id, 'client_delete'))
+		{
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+		$affected_rows = $this->deleteQuery('../client/form/client.tform.php', $client_id);
+
+		$app->remoting_lib->ispconfig_sysuser_delete($client_id);
+
+		return $affected_rows;
+	}
+
+	// -----------------------------------------------------------------------------------------------
+
+	public function client_delete_everything($session_id, $client_id)
+	{
+		global $app, $conf;
+
+		if(!$this->checkPerm($session_id, 'client_delete_everything')) {
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+
 		$client_id = $app->functions->intval($client_id);
 
-		if($client_id > 0) {			
+		if($client_id > 0) {
 			//* remove the group of the client from the resellers group
 			$parent_client_id = $app->functions->intval($this->dataRecord['parent_client_id']);
 			$parent_user = $app->db->queryOneRecord("SELECT userid FROM sys_user WHERE client_id = $parent_client_id");
 			$client_group = $app->db->queryOneRecord("SELECT groupid FROM sys_group WHERE client_id = $client_id");
-			$app->auth->remove_group_from_user($parent_user['userid'],$client_group['groupid']);
-			
+			$app->auth->remove_group_from_user($parent_user['userid'], $client_group['groupid']);
+
 			//* delete the group of the client
 			$app->db->query("DELETE FROM sys_group WHERE client_id = $client_id");
-			
+
 			//* delete the sys user(s) of the client
 			$app->db->query("DELETE FROM sys_user WHERE client_id = $client_id");
-			
+
 			//* Delete all records (sub-clients, mail, web, etc....)  of this client.
 			$tables = 'client,dns_rr,dns_soa,dns_slave,ftp_user,mail_access,mail_content_filter,mail_domain,mail_forwarding,mail_get,mail_user,mail_user_filter,shell_user,spamfilter_users,support_message,web_database,web_database_user,web_domain,web_traffic';
-			$tables_array = explode(',',$tables);
+			$tables_array = explode(',', $tables);
 			$client_group_id = $app->functions->intval($client_group['groupid']);
-			
+
 			if($client_group_id > 1) {
 				foreach($tables_array as $table) {
 					if($table != '') {
@@ -380,112 +380,116 @@
 								}
 							}
 						}
-						
+
 					}
 				}
 			}
-			
+
 		}
-        
+
 		if (!$this->checkPerm($session_id, 'client_delete')) {
-			throw new SoapFault('permission_denied','You do not have the permissions to access this function.');
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 			return false;
 		}
-		$affected_rows = $this->deleteQuery('../client/form/client.tform.php',$client_id);
+		$affected_rows = $this->deleteQuery('../client/form/client.tform.php', $client_id);
 
-        return $affected_rows;
+		return $affected_rows;
 	}
+
 	/**
 	 * Get sys_user information by username
-	 * @param	int		session id
-	 * @param	string	user's name  
-	 * @return	mixed	false if error
-	 * @author	Julio Montoya <gugli100@gmail.com> BeezNest 2010
+	 * @param int  session id
+	 * @param string user's name
+	 * @return mixed false if error
+	 * @author Julio Montoya <gugli100@gmail.com> BeezNest 2010
 	 */
+
+
 	public function client_get_by_username($session_id, $username) {
-        global $app;
-        if(!$this->checkPerm($session_id, 'client_get_by_username')) {
+		global $app;
+		if(!$this->checkPerm($session_id, 'client_get_by_username')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 			return false;
-        }
-        $username = $app->db->quote($username);
-        $rec = $app->db->queryOneRecord("SELECT * FROM sys_user WHERE username = '".$username."'");
-        if (isset($rec)) {
+		}
+		$username = $app->db->quote($username);
+		$rec = $app->db->queryOneRecord("SELECT * FROM sys_user WHERE username = '".$username."'");
+		if (isset($rec)) {
 			return $rec;
-        } else {
+		} else {
 			throw new SoapFault('no_client_found', 'There is no user account for this user name.');
 			return false;
-        }
-    }
-      /**
-       * Get All client_id's from database
-       * @param int	session_id
-       * @return Array of all client_id's
-       */
-	public function client_get_all($session_id) {
-	  global $app;
-	  if(!$this->checkPerm($session_id, 'client_get_all')) {
-	    throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
-	    return false;
-	  }
-	  $result = $app->db->queryAllRecords("SELECT client_id FROM client WHERE 1");
-	  if(!$result) {
-	    return false;
-	  }
-	  foreach( $result as $record) {
-	    $rarrary[] = $record['client_id'];
-	  }
-	  return $rarrary;
+		}
 	}
 
-    /**
-     * Changes client password
-     * 
-  	 * @param	int		session id
-  	 * @param	int		client	id
-  	 * @param	string	new password
-  	 * @return	bool	true if success 
-	 * @author	Julio Montoya <gugli100@gmail.com> BeezNest 2010
-     * 
-     */
-    public function client_change_password($session_id, $client_id, $new_password) {
-        global $app;
-
-        if(!$this->checkPerm($session_id, 'client_change_password')) {
+	/**
+	 * Get All client_id's from database
+	 * @param int session_id
+	 * @return Array of all client_id's
+	 */
+	public function client_get_all($session_id) {
+		global $app;
+		if(!$this->checkPerm($session_id, 'client_get_all')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
-            return false;
-        }
-        $client_id = $app->functions->intval($client_id);
-        $client = $app->db->queryOneRecord("SELECT client_id FROM client WHERE client_id = ".$client_id);
-        if($client['client_id'] > 0) {
-            $new_password = $app->db->quote($new_password);
-            $sql = "UPDATE client SET password = md5('".($new_password)."') 	WHERE client_id = ".$client_id;
-            $app->db->query($sql);            
-            $sql = "UPDATE sys_user SET passwort = md5('".($new_password)."') 	WHERE client_id = ".$client_id;
-            $app->db->query($sql);            
-            return true;
-        } else {
-			throw new SoapFault('no_client_found', 'There is no user account for this client_id');
 			return false;
-        }
-    }
+		}
+		$result = $app->db->queryAllRecords("SELECT client_id FROM client WHERE 1");
+		if(!$result) {
+			return false;
+		}
+		foreach( $result as $record) {
+			$rarrary[] = $record['client_id'];
+		}
+		return $rarrary;
+	}
 
 	/**
-	 * 	Get all client templates
-	 *	@param 	int		session id
-	 *	@author	Julio Montoya <gugli100@gmail.com> BeezNest 2010
+	 * Changes client password
+	 *
+	 * @param int  session id
+	 * @param int  client id
+	 * @param string new password
+	 * @return bool true if success
+	 * @author Julio Montoya <gugli100@gmail.com> BeezNest 2010
+	 *
+	 */
+	public function client_change_password($session_id, $client_id, $new_password) {
+		global $app;
+
+		if(!$this->checkPerm($session_id, 'client_change_password')) {
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
+		}
+		$client_id = $app->functions->intval($client_id);
+		$client = $app->db->queryOneRecord("SELECT client_id FROM client WHERE client_id = ".$client_id);
+		if($client['client_id'] > 0) {
+			$new_password = $app->db->quote($new_password);
+			$sql = "UPDATE client SET password = md5('".($new_password)."') 	WHERE client_id = ".$client_id;
+			$app->db->query($sql);
+			$sql = "UPDATE sys_user SET passwort = md5('".($new_password)."') 	WHERE client_id = ".$client_id;
+			$app->db->query($sql);
+			return true;
+		} else {
+			throw new SoapFault('no_client_found', 'There is no user account for this client_id');
+			return false;
+		}
+	}
+
+	/**
+	 *  Get all client templates
+	 * @param  int  session id
+	 * @author Julio Montoya <gugli100@gmail.com> BeezNest 2010
 	 */
 	public function client_templates_get_all($session_id) {
 		global $app;
 		if(!$this->checkPerm($session_id, 'client_templates_get_all')) {
-			 throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
-            return false;
+			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+			return false;
 		}
-        $sql    = "SELECT * FROM client_template";
+		$sql    = "SELECT * FROM client_template";
 		$result = $app->db->queryAllRecords($sql);
-        return $result;
-   }
+		return $result;
+	}
 
 }
 
-?>
\ No newline at end of file
+?>

--
Gitblit v1.9.1