From f2fc77f29ce81b6493ab629e0f8f9da2b3df857d Mon Sep 17 00:00:00 2001
From: Till Brehm <tbrehm@ispconfig.org>
Date: Thu, 31 Jul 2014 15:46:18 -0400
Subject: [PATCH] Improved input validation.
---
interface/lib/classes/functions.inc.php | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/interface/lib/classes/functions.inc.php b/interface/lib/classes/functions.inc.php
index ddee8da..29feffd 100644
--- a/interface/lib/classes/functions.inc.php
+++ b/interface/lib/classes/functions.inc.php
@@ -427,7 +427,11 @@
public function is_allowed_user($username, $restrict_names = false) {
global $app;
- if($username == 'root') return false;
+ $name_blacklist = array('root','ispconfig','vmail','getmail');
+ if(in_array($username,$name_blacklist)) return false;
+
+ if(preg_match('/^[\w\.\-]{0,32}$/', $username) == false) return false;
+
if($restrict_names == true && preg_match('/^web\d+$/', $username) == false) return false;
return true;
@@ -436,7 +440,11 @@
public function is_allowed_group($groupname, $restrict_names = false) {
global $app;
- if($groupname == 'root') return false;
+ $name_blacklist = array('root','ispconfig','vmail','getmail');
+ if(in_array($groupname,$name_blacklist)) return false;
+
+ if(preg_match('/^[\w\.\-]{0,32}$/', $groupname) == false) return false;
+
if($restrict_names == true && preg_match('/^client\d+$/', $groupname) == false) return false;
return true;
--
Gitblit v1.9.1