Doug Ayers
2013-08-08 3aef0edee192576d0ec945f626755a2c8753d90b
refs
author Doug Ayers <douglascayers@gmail.com>
Thursday, August 8, 2013 23:52 -0400
committer Doug Ayers <douglascayers@gmail.com>
Thursday, August 8, 2013 23:52 -0400
commit3aef0edee192576d0ec945f626755a2c8753d90b
tree bcf2c3aa8e496e9d950966b4ccd67d5d8bdd6873 tree | zip | gz
parent d10fbbe75258cd1c66acebd0aaa71feefdd59f4c view | diff
bugfix to make project links go to project page and not redirect to home page

Problem:
In version 1.3.1, on the MyDashboard page, in the "projects" tab, the project name html links listed in the section are formatted wrong; they are missing the ?p= parameter. Clicking on those links redirects back to the home page (MyDashboard).

What did I expect:
To be taken to the repositories page for the project I clicked.

What code needs to change:
FilterableProjectList.fm at line 9, needs to add the ?p= url parameter.
I'm basing this on how the WicketUtils.getProjectName(PageParameters params) method works at line 457 and logic in ProjectPage.java at lines 95-98.

Although explicitly changing the url to include the query param 'p' is a simple fix, based on what I read about in GitblitParamUrlCodingStrategy and its parent class MixedParamUrlCodingStrategy, it would seem that the url path "/project/foo" should end up adding a request parameter "p=foo" as setup in GitBligWebApp line 141: mount("/project", ProjectPage.class, "p"); However, I'm not familiar with Wicket and don't have Gitblit setup locally to build and run, so not able to debug further.
1 files modified
4 ■■■■ changed files
src/main/java/com/gitblit/wicket/freemarker/templates/FilterableProjectList.fm 4 ●●●● diff | view | raw | blame | history