James Moger
2014-05-23 c828cf2db88956094a31a79741145688876879df
refs
author James Moger <james.moger@gitblit.com>
Friday, May 23, 2014 08:17 -0400
committer James Moger <james.moger@gitblit.com>
Thursday, July 3, 2014 16:57 -0400
commitc828cf2db88956094a31a79741145688876879df
tree 7f9d7e8b0fe7d91350afb79b2baf60f543712150 tree | zip | gz
parent aa1361d04cfe09f90e7d8bece90c00dd6e4185bb view | diff
Use Guice-Servlet rather than custom code and expose the Injector

This is a fairly functional variation of Gitblit with one notable
exception:

The security filters are not working properly.

This is a design flaw in Guice that I have reported upstream [1]. The
general idea is that Guice-Servlet filters are not properly wrapping the
ServletRequest. This has historically been a problem for Guice-Servlet
servlets but Google has fixed most of those issues. Unfortunately, all
the same flaws reported against the servlet delegation also exist in
Guice-Servlet filter delegation. :(

[1]: https://code.google.com/p/google-guice/issues/detail?id=807
1 files added
1 files renamed
10 files modified
2 files deleted
577 ■■■■■ changed files
.classpath 1 ●●●● diff | view | raw | blame | history
build.moxie 4 ●●● diff | view | raw | blame | history
gitblit.iml 11 ●●●●● diff | view | raw | blame | history
src/main/java/WEB-INF/web.xml 18 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/guice/CoreModule.java 4 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/guice/GuiceContext.java 86 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/guice/WebModule.java 99 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/GitblitManager.java 6 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IRuntimeManager.java 3 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/RuntimeManager.java 9 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/servlet/AuthenticationFilter.java 8 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/servlet/GitblitContext.java 81 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/servlet/InjectionContextListener.java 241 ●●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/mock/MockRuntimeManager.java 6 ●●●●● diff | view | raw | blame | history