James Moger
2013-11-17 db4f6b5740c6ea45d9e2209dc569bc18904a8b4d
refs
author James Moger <james.moger@gitblit.com>
Sunday, November 17, 2013 16:15 -0500
committer James Moger <james.moger@gitblit.com>
Tuesday, November 26, 2013 16:07 -0500
commitdb4f6b5740c6ea45d9e2209dc569bc18904a8b4d
tree 8dd6c651876359ea2d66e844b77af29394f8cd1e tree | zip | gz
parent 99d0d4fd66f3490b61c700065b7d16bc4e73f226 view | diff
Define manager interfaces and update all of Gitblit to use managers

These manager interfaces define how the GitBlit singleton will
eventually be split into smaller component managers. The Wicket app and
all servlets have been updated to request the needed managers. There
are _very_ few method signature changes - although there are a handful.

This is a surgical sharding of responsibility based on a proof of
concept refactor. Instead of random references to GittBlit.self()
there are now precise references to the manager interface required to
accomplish some task. Some tasks may require references to multiple
managers.

The code is now littered with calls to GitBlit.getManager(class) and
those familiar with the code-base will no doubt notice the duplication
of methods from IUserService in IUserManager and the addition of
implementation methods in the GitBlit context class. When the
GitBlit class is broken apart and the existing external authentication
user service classes are refactored to AuthenticationService classes,
this will again simplify and flatten. But in order to safely and
cleanly modularize the stable code-base we will have to live with a
little duplication for a short while.

Change-Id: I7314ec8acaab2dcc6092785ed4434cc09fdbbe16
9 files added
88 files modified
2851 ■■■■ changed files
src/main/java/com/gitblit/AccessRestrictionFilter.java 17 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/AuthenticationFilter.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/BranchGraphServlet.java 12 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/DownloadZipServlet.java 10 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/EnforceAuthenticationFilter.java 41 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/FederationClient.java 3 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/FederationPullExecutor.java 44 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/FederationServlet.java 56 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/GCExecutor.java 11 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/GitBlit.java 518 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/GitBlitServer.java 6 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/GitFilter.java 21 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/GitblitUserService.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/HtpasswdUserService.java 7 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/IStoredSettings.java 10 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/LdapUserService.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/LogoServlet.java 10 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/LuceneExecutor.java 12 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/MirrorExecutor.java 11 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/PAMUserService.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/PagesFilter.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/PagesServlet.java 11 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/RedmineUserService.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/RobotsTxtServlet.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/RpcFilter.java 18 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/RpcServlet.java 104 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/SalesforceUserService.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/SparkleShareInviteServlet.java 19 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/SyndicationFilter.java 17 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/SyndicationServlet.java 24 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/WindowsUserService.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/git/GitServlet.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/git/GitblitReceivePack.java 21 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/git/GitblitReceivePackFactory.java 14 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/git/GitblitUploadPackFactory.java 4 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/git/RepositoryResolver.java 8 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IFederationManager.java 177 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IGitblitManager.java 83 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/INotificationManager.java 66 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IProjectManager.java 63 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IRepositoryManager.java 396 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IRuntimeManager.java 103 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/ISessionManager.java 64 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/manager/IUserManager.java 280 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/utils/ActivityUtils.java 21 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/GitBlitWebApp.java 50 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/GitblitWicketFilter.java 23 ●●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/ActivityPage.java 9 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/ChangePasswordPage.java 4 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/EditRepositoryPage.java 2 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/EditTeamPage.java 2 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/EditUserPage.java 4 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/EmptyRepositoryPage.java 2 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/LogoutPage.java 3 ●●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/RepositoryPage.java 2 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/RootPage.java 2 ●●● diff | view | raw | blame | history
src/main/java/com/gitblit/wicket/pages/SessionPage.java 2 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/ActivityTest.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/ArrayUtilsTest.java 5 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/Base64Test.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/ByteFormatTest.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/DiffUtilsTest.java 5 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/FanoutServiceTest.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/FederationTests.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/FileUtilsTest.java 5 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GitBlitSuite.java 11 ●●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GitBlitTest.java 54 ●●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GitDaemonStopTest.java 3 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GitDaemonTest.java 30 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GitServletTest.java 65 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GitblitUnitTest.java 67 ●●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/GroovyScriptTest.java 15 ●●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/HtpasswdUserServiceTest.java 8 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/Issue0259Test.java 3 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/Issue0271Test.java 3 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/JGitUtilsTest.java 8 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/JnaUtilsTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/JsonUtilsTest.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/LdapUserServiceTest.java 7 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/LuceneExecutorTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/MailTest.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/MarkdownUtilsTest.java 4 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/MetricUtilsTest.java 5 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/ModelUtilsTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/ObjectCacheTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/PermissionsTest.java 3 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/PushLogTest.java 2 ●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/RedmineUserServiceTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/RepositoryModelTest.java 13 ●●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/RpcTests.java 7 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/StringUtilsTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/SyndicationUtilsTest.java 5 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/TimeUtilsTest.java 5 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/UserServiceTest.java 6 ●●●● diff | view | raw | blame | history
src/test/java/com/gitblit/tests/X509UtilsTest.java 3 ●●●● diff | view | raw | blame | history
src/test/java/de/akquinet/devops/GitBlit4UITests.java 3 ●●●● diff | view | raw | blame | history
src/test/java/de/akquinet/devops/GitBlitServer4UITests.java 13 ●●●● diff | view | raw | blame | history